Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several CA fixes #1383

Closed
wants to merge 7 commits into from
Closed

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Sep 29, 2024

Add:

Example project:
positive_negative_CA.tar.gz

Example:
image

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

Add:
- CA data: use actual total instead of sum(abs)
- CA data: make distinction between positive and negative rest values (LCA-ActivityBrowser#886)
- CA data: sort based on average of row instead of first column (LCA-ActivityBrowser#887)
- CA table: consistent dropping of empty (rest) rows (LCA-ActivityBrowser#1044)
- CA figure: add marker to show total score when both positive and negative results present (LCA-ActivityBrowser#647)
@marc-vdm marc-vdm added bug Issues/PRs related to bugs change PRs related to minor changes to AB labels Sep 29, 2024
@coveralls
Copy link

coveralls commented Sep 29, 2024

Coverage Status

coverage: 54.193% (-0.07%) from 54.26%
when pulling b0a610f on marc-vdm:CA_updates
into 901f39c on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm added this to the 2.11.0 milestone Sep 30, 2024
@marc-vdm
Copy link
Member Author

marc-vdm commented Oct 2, 2024

closing as merged into #1046

@marc-vdm marc-vdm closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs change PRs related to minor changes to AB
Projects
None yet
2 participants